Issue 10867070: Support removing dead packages with `pub install`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867070: Support removing dead packages with `pub install`. (Closed)

Created:
8 years, 4 months ago by nweiz

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support removing dead packages with `pub install`. Committed: https://code.google.com/p/dart/source/detail?r=11356

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+274 lines, -5 lines)			Patch
M	utils/pub/entrypoint.dart	View	2 chunks	+27 lines, -4 lines	2 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_install_repo_test.dart	View	1 chunk	+100 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_update_repo_test.dart	View	1 chunk	+100 lines, -0 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	3 chunks	+37 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://chromiumcodereview.appspot.com/10867070/diff/1/utils/pub/entrypoint.dart File utils/pub/entrypoint.dart (right): https://chromiumcodereview.appspot.com/10867070/diff/1/utils/pub/entrypoint.dart#newcode198 utils/pub/entrypoint.dart:198: new List.from(setMinus(existingDependencies, dependenciesToKeep)); Indent +2.

8 years, 4 months ago (2012-08-25 00:13:30 UTC) #2

nweiz

8 years, 4 months ago (2012-08-25 00:17:49 UTC) #3

https://chromiumcodereview.appspot.com/10867070/diff/1/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://chromiumcodereview.appspot.com/10867070/diff/1/utils/pub/entrypoint.d...
utils/pub/entrypoint.dart:198: new List.from(setMinus(existingDependencies,
dependenciesToKeep));
On 2012/08/25 00:13:30, Bob Nystrom wrote:
> Indent +2.

Done.

Expand Messages | Collapse Messages