Use Heap::kOld when allocating objects for script snapshots.

Use Heap::kOld when allocating objects for script snapshots.
Committed: https://code.google.com/p/dart/source/detail?r=11486

[cshapiro, 2012-08-25 03:30:11]

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/raw_obje...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/raw_obje...
runtime/vm/raw_object_snapshot.cc:384: InstantiatedTypeArguments::ZoneHandle(
Perhaps I have missed something subtle, but the change on this line looks like
noise.  If I am indeed right, can we remove this delta?

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/snapshot...
runtime/vm/snapshot.cc:117: static Heap::Space space(Snapshot::Kind kind) {
Is this change missing heap.h or am I confused?

Lowercase method names are reserved for getters and setters and other, likely to
be in-lined, functions.  Having this be an out of line static function is a
little bit iffy given the context.  My preference would be to capitalize this
and make it look like any other ordinary method call or hoisting this out into
heap.h to have a similar effect.

[siva, 2012-08-27 17:15:21]

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/raw_obje...
File runtime/vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/raw_obje...
runtime/vm/raw_object_snapshot.cc:384: InstantiatedTypeArguments::ZoneHandle(
On 2012/08/25 03:30:11, cshapiro wrote:
> Perhaps I have missed something subtle, but the change on this line looks like
> noise.  If I am indeed right, can we remove this delta?

Done.

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/10867046/diff/5001/runtime/vm/snapshot...
runtime/vm/snapshot.cc:117: static Heap::Space space(Snapshot::Kind kind) {
I would have preferred to put this in snapshot.h but it causes cyclic dependency
issues as snapshot.h is included in  raw_object.h which is included in
scavenger.h

I have made this a macro HEAPSPACE(kind).

On 2012/08/25 03:30:11, cshapiro wrote:
> Is this change missing heap.h or am I confused?
> 
> Lowercase method names are reserved for getters and setters and other, likely
to
> be in-lined, functions.  Having this be an out of line static function is a
> little bit iffy given the context.  My preference would be to capitalize this
> and make it look like any other ordinary method call or hoisting this out into
> heap.h to have a similar effect.

[cshapiro, 2012-08-27 23:35:41]

lgtm