Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 10867011: Deal with the JS helper separately from the 'native' keyword. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)
Modified:
8 years, 4 months ago
Reviewers:
Johnni Winther, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Deal with the JS helper separately from the 'native' keyword. Another change to prepare for the removal of the corelib Math object in favor of the dart:math library. R=ahe@google.com,johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M lib/compiler/implementation/compiler.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M lib/compiler/implementation/leg.dart View 2 chunks +2 lines, -1 line 0 comments Download
M lib/compiler/implementation/native_handler.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/mirrors/dart2js_mirror.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
8 years, 4 months ago (2012-08-22 13:38:23 UTC) #1
ahe
LGTM!
8 years, 4 months ago (2012-08-22 13:51:27 UTC) #2
Johnni Winther
8 years, 4 months ago (2012-08-22 13:53:07 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698