Issue 10867005: Made get_archive.py resilient to 403 forbidden errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10867005: Made get_archive.py resilient to 403 forbidden errors. (Closed)

Created:
8 years, 4 months ago by Emily Fortuna

Modified:
8 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Made get_archive.py resilient to 403 forbidden errors. Committed: https://code.google.com/p/dart/source/detail?r=11178

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	tools/get_archive.py	View	1	1 chunk	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 4 months ago (2012-08-22 18:08:09 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10867005/diff/2001/tools/get_archive.py
File tools/get_archive.py (right):

https://chromiumcodereview.appspot.com/10867005/diff/2001/tools/get_archive.p...
tools/get_archive.py:167: returncode, out, err = Gsutil('cp', latest, 'file://'
+ temp_zip)
It doesn't look like you're using err here.

Expand Messages | Collapse Messages