Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 10862002: Apply vsm's suggestion of keeping a table of "earliest revisions" (Closed)

Created:
8 years, 4 months ago by Emily Fortuna
Modified:
8 years, 4 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Apply vsm's suggestion of keeping a table of "earliest revisions" Committed: https://code.google.com/p/dart/source/detail?r=11002

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -40 lines) Patch
M tools/get_archive.py View 1 15 chunks +42 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
Also applied the new "Python style" rules while I was here.
8 years, 4 months ago (2012-08-20 21:18:56 UTC) #1
vsm
8 years, 4 months ago (2012-08-20 21:25:47 UTC) #2
lgtm

https://chromiumcodereview.appspot.com/10862002/diff/1001/tools/get_archive.py
File tools/get_archive.py (right):

https://chromiumcodereview.appspot.com/10862002/diff/1001/tools/get_archive.p...
tools/get_archive.py:306: def Main():
I think the style is still lowercase for main, but I could be wrong.

Powered by Google App Engine
This is Rietveld 408576698