Issue 10861041: Provide an Expando implementation for the VM.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -14 lines)			Patch
M	corelib/src/corelib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/lib/expando.dart	View	1 2 3	1 chunk	+98 lines, -0 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/lib/lib_sources.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/lib/weak_property.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/lib/weak_property.dart	View	1 2 3	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	5 chunks	+10 lines, -7 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

http://codereview.chromium.org/10861041/diff/2001/runtime/lib/expando.dart File runtime/lib/expando.dart (right): http://codereview.chromium.org/10861041/diff/2001/runtime/lib/expando.dart#newcode17 runtime/lib/expando.dart:17: if (list[i] !== null) { How can this ever ...

8 years, 4 months ago (2012-08-21 23:19:40 UTC) #2

cshapiro

PTAL http://codereview.chromium.org/10861041/diff/2001/runtime/lib/expando.dart File runtime/lib/expando.dart (right): http://codereview.chromium.org/10861041/diff/2001/runtime/lib/expando.dart#newcode17 runtime/lib/expando.dart:17: if (list[i] !== null) { This was needed ...

8 years, 4 months ago (2012-08-22 02:37:35 UTC) #3

Ivan Posva

8 years, 4 months ago (2012-08-22 20:39:34 UTC) #4

LGTM with comment.

-Ivan

https://chromiumcodereview.appspot.com/10861041/diff/5001/runtime/lib/weak_pr...
File runtime/lib/weak_property.dart (right):

https://chromiumcodereview.appspot.com/10861041/diff/5001/runtime/lib/weak_pr...
runtime/lib/weak_property.dart:5: class WeakProperty {
Missed this on the first review: this needs to be a private class.

Expand Messages | Collapse Messages

Issue 10861041: Provide an Expando implementation for the VM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : add missing whitespace #

Patch Set 3 : address review comments #

Patch Set 4 : make WeakProperty private #

Messages