Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 10861029: Properly rename type variables. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -6 lines) Patch
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 1 2 chunks +19 lines, -4 lines 1 comment Download
M lib/compiler/implementation/dart_backend/renamer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 2 chunks +34 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-08-21 13:14:30 UTC) #1
Roman
lgtm awesome
8 years, 4 months ago (2012-08-21 13:22:42 UTC) #2
Roman
I noticed that we may have missed something here. Try to run dart2dart with minifier ...
8 years, 4 months ago (2012-08-22 08:30:47 UTC) #3
Roman
8 years, 4 months ago (2012-08-22 08:32:07 UTC) #4
https://chromiumcodereview.appspot.com/10861029/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10861029/diff/4001/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:449:
node.visitChildren(this);
probably my last change in ClassNode affects this.

Powered by Google App Engine
This is Rietveld 408576698