Issue 10861023: Currently we use a generated number as the class id for object class, this change tries to pin it t…

Issue 10861023: Currently we use a generated number as the class id for object class, this change tries to pin it t… (Closed)

Created:
8 years, 4 months ago by siva

Modified:
8 years, 4 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Currently we use a generated number as the class id for object class, this change tries to pin it to kInstanceCid so that we can do all the checks for object class using this class id. Committed: https://code.google.com/p/dart/source/detail?r=11091

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -23 lines)			Patch
M	vm/object.cc	View	1	5 chunks	+8 lines, -20 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1	1 chunk	+10 lines, -1 line	0 comments	Download
M	vm/snapshot.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10861023/diff/1/vm/raw_object_snapshot.cc File vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/10861023/diff/1/vm/raw_object_snapshot.cc#newcode45 vm/raw_object_snapshot.cc:45: ASSERT(class_id >= kInstanceCid && class_id <= kWeakPropertyCid); Add ...

8 years, 4 months ago (2012-08-21 00:57:39 UTC) #2

regis

LGTM https://chromiumcodereview.appspot.com/10861023/diff/1/vm/object.cc File vm/object.cc (right): https://chromiumcodereview.appspot.com/10861023/diff/1/vm/object.cc#newcode1256 vm/object.cc:1256: ASSERT(FakeObject::kClassId != kInstanceCid && Add parenthesis.

8 years, 4 months ago (2012-08-21 01:08:12 UTC) #3

siva

8 years, 4 months ago (2012-08-21 01:23:29 UTC) #4

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/object.cc#newcode1256
vm/object.cc:1256: ASSERT(FakeObject::kClassId != kInstanceCid &&
On 2012/08/21 01:08:12, regis wrote:
> Add parenthesis.

Done.

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/raw_object_snapshot.cc
File vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/raw_object_snapshot...
vm/raw_object_snapshot.cc:45: ASSERT(class_id >= kInstanceCid && class_id <=
kWeakPropertyCid);
On 2012/08/21 00:57:39, srdjan wrote:
> Add parenthesis.

Done.

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/snapshot.cc
File vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/10861023/diff/1/vm/snapshot.cc#newcode417
vm/snapshot.cc:417: ASSERT(class_id >= kInstanceCid && class_id <=
kWeakPropertyCid);
On 2012/08/21 00:57:39, srdjan wrote:
> Add parenthesis

Done.

Expand Messages | Collapse Messages