Issue 10861016: Introduce renameNodes helper to factor out common pattern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10861016: Introduce renameNodes helper to factor out common pattern. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Introduce renameNodes helper to factor out common pattern. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=11022

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -16 lines)			Patch
	M	lib/compiler/implementation/dart_backend/renamer.dart	View		1 chunk	+13 lines, -16 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm You should probably merge this with sorted rename CL. https://chromiumcodereview.appspot.com/10861016/diff/1/lib/compiler/implementation/dart_backend/renamer.dart File lib/compiler/implementation/dart_backend/renamer.dart (right): https://chromiumcodereview.appspot.com/10861016/diff/1/lib/compiler/implementation/dart_backend/renamer.dart#newcode59 ...

8 years, 4 months ago (2012-08-21 08:02:44 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-21 09:11:10 UTC) #3

Thanks a lot for review, submitting after running the tests.  And yes, I'll have
some fun time merging CLs.

https://chromiumcodereview.appspot.com/10861016/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/renamer.dart (right):

https://chromiumcodereview.appspot.com/10861016/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/renamer.dart:59:
renameNodes(placeholderCollector.nullNodes, (_) => '');
That's the common idiom to mark unused argument.  There is even a proposal to
make supported by language to allow (_, _, _, x) => x.

On 2012/08/21 08:02:44, Roman wrote:
> did you use '_' instead of 'node' to save 3 chars and not confuse reader? same
> below
>

Expand Messages | Collapse Messages