Issue 10860074: Add dart:mirrors to the SDK - this will allow the editor to resolve the mirrors library and the typ…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10860074: Add dart:mirrors to the SDK - this will allow the editor to resolve the mirrors library and the typ… (Closed)

Created:
8 years, 4 months ago by devoncarew

Modified:
8 years, 4 months ago

Reviewers:
dgrove, danrubel

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add dart:mirrors to the SDK - this will allow the editor to resolve the mirrors library and the types within it. Committed: https://code.google.com/p/dart/source/detail?r=11099

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
M	lib/_internal/libraries.dart	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lib/config/import_any.config	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/create_sdk.py	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgrove

lgtm https://chromiumcodereview.appspot.com/10860074/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10860074/diff/1/tools/create_sdk.py#newcode339 tools/create_sdk.py:339: for library in ['_internal', 'crypto', 'json', 'math', 'mirrors', ...

8 years, 4 months ago (2012-08-21 18:58:07 UTC) #2

danrubel

Need to update lib/config/import_any.config as well because we are not switched over to use libraries.dart ...

8 years, 4 months ago (2012-08-21 19:09:14 UTC) #3

devoncarew

> Need to update lib/config/import_any.config as well Sounds good; I added mirrors to import_any.config and ...

8 years, 4 months ago (2012-08-21 19:52:34 UTC) #4

lgtm

Expand Messages | Collapse Messages

Issue 10860074: Add dart:mirrors to the SDK - this will allow the editor to resolve the mirrors library and the typ… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages