Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 10860050: Update XMLHttpRequest documentation. (Closed)

Created:
8 years, 4 months ago by Emily Fortuna
Modified:
8 years, 4 months ago
Reviewers:
vsm, sethladd, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update XMLHttpRequest documentation. Committed: https://code.google.com/p/dart/source/detail?r=11071

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -206 lines) Patch
A + lib/html/doc/interface/HttpRequest.dartdoc View 1 3 chunks +10 lines, -6 lines 0 comments Download
A + lib/html/doc/interface/HttpRequestException.dartdoc View 1 chunk +1 line, -1 line 0 comments Download
A + lib/html/doc/interface/HttpRequestProgressEvent.dartdoc View 1 chunk +1 line, -1 line 0 comments Download
A + lib/html/doc/interface/HttpRequestUpload.dartdoc View 2 chunks +3 lines, -3 lines 0 comments Download
D lib/html/doc/interface/XMLHttpRequest.dartdoc View 1 chunk +0 lines, -111 lines 0 comments Download
D lib/html/doc/interface/XMLHttpRequestException.dartdoc View 1 chunk +0 lines, -27 lines 0 comments Download
D lib/html/doc/interface/XMLHttpRequestProgressEvent.dartdoc View 1 chunk +0 lines, -17 lines 0 comments Download
D lib/html/doc/interface/XMLHttpRequestUpload.dartdoc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emily Fortuna
My comment connecting HttpRequest to XMLHttpRequest is woefully bad. I'll happily take suggestions on how ...
8 years, 4 months ago (2012-08-20 21:32:53 UTC) #1
sethladd
https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc File lib/html/doc/interface/HttpRequest.dartdoc (right): https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc#newcode10 lib/html/doc/interface/HttpRequest.dartdoc:10: * HttpRequest is Dart's name for the XMLHttpRequest object, ...
8 years, 4 months ago (2012-08-20 21:36:20 UTC) #2
sra1
https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc File lib/html/doc/interface/HttpRequest.dartdoc (right): https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc#newcode55 lib/html/doc/interface/HttpRequest.dartdoc:55: final Document responseXML; /*TODO(efortuna): rename, too?*/ No rename. The ...
8 years, 4 months ago (2012-08-20 21:38:33 UTC) #3
Emily Fortuna
https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc File lib/html/doc/interface/HttpRequest.dartdoc (right): https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface/HttpRequest.dartdoc#newcode10 lib/html/doc/interface/HttpRequest.dartdoc:10: * HttpRequest is Dart's name for the XMLHttpRequest object, ...
8 years, 4 months ago (2012-08-20 21:40:15 UTC) #4
sethladd
8 years, 4 months ago (2012-08-20 21:43:32 UTC) #5
lgtm

https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface...
File lib/html/doc/interface/HttpRequest.dartdoc (right):

https://chromiumcodereview.appspot.com/10860050/diff/1/lib/html/doc/interface...
lib/html/doc/interface/HttpRequest.dartdoc:10: * HttpRequest is Dart's name for
the XMLHttpRequest object, as described below.
Oh, neat! Didn't realize we supported both.

Powered by Google App Engine
This is Rietveld 408576698