Issue 10860036: Few tweaks to the generated code to avoid eg parenthesis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10860036: Few tweaks to the generated code to avoid eg parenthesis. (Closed)

Created:
8 years, 4 months ago by ngeoffray

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Few tweaks to the generated code to avoid eg parenthesis. Committed: https://code.google.com/p/dart/source/detail?r=10982

Patch Set 1 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	lib/compiler/implementation/js/nodes.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lib/compiler/implementation/js/printer.dart	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Have you checked that every instance of JS actually has the necessary parentheses? If so ...

8 years, 4 months ago (2012-08-20 12:40:21 UTC) #2

ngeoffray

8 years, 4 months ago (2012-08-20 15:57:10 UTC) #3

On 2012/08/20 12:40:21, Lasse Reichstein Nielsen wrote:
> Have you checked that every instance of JS actually has the necessary
> parentheses?
> If so LGTM.

I have run all possible tests. We have many occurences of JS, and they ought to
be extensively tested.

Expand Messages | Collapse Messages