Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10857059: Look for SDK packages in "pkg" in addition to "lib". (Closed)

Created:
8 years, 4 months ago by Bob Nystrom
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Look for SDK packages in "pkg" in addition to "lib". Committed: https://code.google.com/p/dart/source/detail?r=10912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M utils/pub/sdk_source.dart View 1 chunk +13 lines, -3 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Now that some SDK packages are in "pkg", pub needs to look there too. Fixes ...
8 years, 4 months ago (2012-08-17 17:57:13 UTC) #1
dgrove
lgtm
8 years, 4 months ago (2012-08-17 17:58:52 UTC) #2
darren.neimke
8 years, 3 months ago (2012-09-08 08:16:18 UTC) #3
On 2012/08/17 17:58:52, dgrove wrote:
> lgtm

I'm still seeing this issue.  Running Dart SDK version 12085 on Win7 64bit and I
get this error whenever I attempt to use pub over a library which references
unittest.

Powered by Google App Engine
This is Rietveld 408576698