Issue 10857029: Revert "Sharing of sources for corelib date implementation between VM and"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857029: Revert "Sharing of sources for corelib date implementation between VM and" (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Sharing of sources for corelib date implementation between VM and" Revert "Fix create_sdk." Revert "Fix bad merge. 'unified' directory is gone." We need to update dartc to not check that final fields are initialized for 'external' constructors (it does not have the body and initializers for those). R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10797

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+202 lines, -556 lines)			Patch
M	corelib/src/implementation/corelib_impl_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	corelib/src/implementation/date.dart	View	1 chunk	+0 lines, -184 lines	0 comments	Download
A +	corelib/unified/core/date.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	corelib/unified/core/implementation/date.dart	View	4 chunks	+5 lines, -8 lines	0 comments	Download
M	lib/compiler/implementation/lib/core.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/lib/coreimpl_patch.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
A +	runtime/lib/date.dart	View	9 chunks	+192 lines, -27 lines	0 comments	Download
D	runtime/lib/date_patch.dart	View	1 chunk	+0 lines, -327 lines	0 comments	Download
M	runtime/lib/lib_impl_sources.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/create_sdk.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages