Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10855248: Copy all frog/native tests to dart2js_foreign. (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
ngeoffray, kasperl
CC:
reviews_dartlang.org, sra1, dgrove
Visibility:
Public.

Description

Copy all frog/native tests to dart2js_foreign. Committed: https://code.google.com/p/dart/source/detail?r=11020

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Address review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, --34 lines) Patch
A dart/tests/compiler/dart2js_foreign/dart2js_foreign.status View 1 1 chunk +57 lines, -0 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/foreign_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_call_arity1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_call_arity2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_call_arity3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_checked_arguments1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_checked_fields_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_avoids_hidden_name_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_inheritance1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_inheritance2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_inheritance3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_inheritance4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_is_check1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_is_check3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_class_with_dart_methods_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_closure_identity_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_exceptions1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_field_rename_1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_field_rename_2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib1.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_library_same_name_used_lib2.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_library_same_name_used_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_literal_class_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_method_rename1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_method_rename2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_method_rename3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_method_with_keyword_name_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_missing_method1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_missing_method2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_named_constructors2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_named_constructors3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_no_such_method_exception2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_no_such_method_exception3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_no_such_method_exception4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_no_such_method_exception5_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_no_such_method_exception_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_null_closure_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_null_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_parameter_names_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_property_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_use_native_name_in_table_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_window1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_window2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_wrapping_function2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_wrapping_function3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/tests/compiler/dart2js_foreign/native_wrapping_function_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M dart/tests/compiler/dart2js_native/dart2js_native.status View 1 1 chunk +1 line, -10 lines 1 comment Download
M dart/tools/test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/utils/compiler/buildbot.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
I'm starting on implementing metadata. The first goal is to support enough metadata to use ...
8 years, 4 months ago (2012-08-20 16:31:47 UTC) #1
ahe
+dgrove Dan: FYI, I'm also doing some cleaning. There is a bunch of *_frog_test.dart files ...
8 years, 4 months ago (2012-08-20 19:37:08 UTC) #2
kasperl
LGTM. https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/dart2js_foreign/dart2js_foreign.status File dart/tests/compiler/dart2js_foreign/dart2js_foreign.status (right): https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/dart2js_foreign/dart2js_foreign.status#newcode56 dart/tests/compiler/dart2js_foreign/dart2js_foreign.status:56: [ $compiler == dartc || $runtime == drt ...
8 years, 4 months ago (2012-08-21 05:37:10 UTC) #3
ngeoffray
LGTM! https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/dart2js_foreign/dart2js_foreign.status File dart/tests/compiler/dart2js_foreign/dart2js_foreign.status (right): https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/dart2js_foreign/dart2js_foreign.status#newcode56 dart/tests/compiler/dart2js_foreign/dart2js_foreign.status:56: [ $compiler == dartc || $runtime == drt ...
8 years, 4 months ago (2012-08-21 06:29:43 UTC) #4
ahe
8 years, 4 months ago (2012-08-21 08:56:08 UTC) #5
Thank you, Kasper and Nicolas.

https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/d...
File dart/tests/compiler/dart2js_foreign/dart2js_foreign.status (right):

https://chromiumcodereview.appspot.com/10855248/diff/50/dart/tests/compiler/d...
dart/tests/compiler/dart2js_foreign/dart2js_foreign.status:56: [ $compiler ==
dartc || $runtime == drt || $runtime == ie || $runtime == chrome || $runtime ==
safari || $runtime == ff || $runtime == opera ]
On 2012/08/21 05:37:10, kasperl wrote:
> Did we ever add a $browser flag that would make this condition simpler to
write?

Done.

https://chromiumcodereview.appspot.com/10855248/diff/7001/dart/tests/compiler...
File dart/tests/compiler/dart2js_native/dart2js_native.status (right):

https://chromiumcodereview.appspot.com/10855248/diff/7001/dart/tests/compiler...
dart/tests/compiler/dart2js_native/dart2js_native.status:8: [ $compiler == dartc
|| $browser ]
Updated here as well.

Powered by Google App Engine
This is Rietveld 408576698