Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 10855197: Fix HttpHeaders.date and add HttpHeaders.ifModifiedSince. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix HttpHeaders.date and add HttpHeaders.ifModifiedSince. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10793

Patch Set 1 #

Patch Set 2 : Also parse other date values to a Http date format. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -4 lines) Patch
M runtime/bin/http.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M runtime/bin/http_impl.dart View 1 4 chunks +33 lines, -2 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
8 years, 4 months ago (2012-08-16 06:18:42 UTC) #1
Søren Gjesse
lgtm
8 years, 4 months ago (2012-08-16 06:28:36 UTC) #2
Anders Johnsen
PTAL
8 years, 4 months ago (2012-08-16 06:49:41 UTC) #3
Søren Gjesse
8 years, 4 months ago (2012-08-16 06:50:35 UTC) #4
LEBTM (looke even better to me)

Powered by Google App Engine
This is Rietveld 408576698