Issue 10855176: And hopefully the last reference to layoutTestController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855176: And hopefully the last reference to layoutTestController. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

And hopefully the last reference to layoutTestController. TBR=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=10743

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/html/window_open_test.dart	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

https://chromiumcodereview.appspot.com/10855176/diff/1/tests/html/window_open_test.dart File tests/html/window_open_test.dart (right): https://chromiumcodereview.appspot.com/10855176/diff/1/tests/html/window_open_test.dart#newcode12 tests/html/window_open_test.dart:12: evaluateJavaScript('(testRunner || layoutTestController).setCanOpenWindows()'); Is testRunner getter somehow exposed to ...

8 years, 4 months ago (2012-08-21 16:51:39 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-21 18:00:38 UTC) #3

https://chromiumcodereview.appspot.com/10855176/diff/1/tests/html/window_open...
File tests/html/window_open_test.dart (right):

https://chromiumcodereview.appspot.com/10855176/diff/1/tests/html/window_open...
tests/html/window_open_test.dart:12: evaluateJavaScript('(testRunner ||
layoutTestController).setCanOpenWindows()');
On 2012/08/21 16:51:39, podivilov wrote:
> Is testRunner getter somehow exposed to JavaScript?

Sorry, what do you mean?

testRunner is now official name for former layoutTestController

Expand Messages | Collapse Messages