Make the closure-to-class translator more accessible. It can now be

Make the closure-to-class translator more accessible. It can now be
used by the type-inference algorithm.

Committed: https://code.google.com/p/dart/source/detail?r=10648

[ahe, 2012-08-14 12:54:38]

LGTM, only nits.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:5: #library("closureToClassMapper");
I like an empty line between #library and #import.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:36: ClosureToClassMapping
getMappingForNestedFunction(FunctionExpression node) {
Should this be wrapped in measure?

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:109: class ClosureToClassMapping {
If you don't like this name, consider "ClosureClassMap" or "Closure2ClassMap".

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:396: ClosureToClassMapping
globalizeClosure(FunctionExpression node, Element element) {
Long line.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:411: callElement, thisElement);
Indentation.

[floitsch, 2012-08-14 14:16:32]

Also needed to fix a type (which was missing the library prefix).

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:5: #library("closureToClassMapper");
On 2012/08/14 12:54:38, ahe wrote:
> I like an empty line between #library and #import.

Done.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:36: ClosureToClassMapping
getMappingForNestedFunction(FunctionExpression node) {
On 2012/08/14 12:54:38, ahe wrote:
> Should this be wrapped in measure?

It is just looking up in a hashmap, so the cost should be minimal. But it cannot
hurt (much) either.
done.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:109: class ClosureToClassMapping {
On 2012/08/14 12:54:38, ahe wrote:
> If you don't like this name, consider "ClosureClassMap" or "Closure2ClassMap".

As you can see I was struggling with the name. Happy to pick ClosureClassMap.
done.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:396: ClosureToClassMapping
globalizeClosure(FunctionExpression node, Element element) {
On 2012/08/14 12:54:38, ahe wrote:
> Long line.

not anymore after the renaming.

https://chromiumcodereview.appspot.com/10855146/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:411: callElement, thisElement);
On 2012/08/14 12:54:38, ahe wrote:
> Indentation.

Done.

[ahe, 2012-08-14 17:33:11]

SLGTM :-)