Issue 10855134: In checked mode, make sure the ssa compiler propagates the checked types of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855134: In checked mode, make sure the ssa compiler propagates the checked types of (Closed)

Created:
8 years, 4 months ago by regis

Modified:
8 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In checked mode, make sure the ssa compiler propagates the checked types of incoming arguments. Propagate the type of the receiver and of the constructor phase argument. Committed: https://code.google.com/p/dart/source/detail?r=10605

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -8 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+17 lines, -5 lines	0 comments	Download
	M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/10855134/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://chromiumcodereview.appspot.com/10855134/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode655 runtime/vm/flow_graph_optimizer.cc:655: // For now, we do not known anything ...

8 years, 4 months ago (2012-08-13 21:07:38 UTC) #2

regis

8 years, 4 months ago (2012-08-13 21:09:38 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10855134/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10855134/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:655: // For now, we do not known anything
about the argument type and therefore set
On 2012/08/13 21:07:38, srdjan wrote:
> s/known/know/

Done.

Expand Messages | Collapse Messages