Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 10855127: Fix the case of function field via this initialization. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the case of function field via this initialization. The problematic code is like: class C { Function f; C(int this.f()); } In this case Send's selector is actually a FunctionExpression. Currently it gets unparsed weirdly: C(this.int f()), but DartVM accepts that so let leave it in this state for now. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-08-13 16:25:57 UTC) #1
Anton Muhin
friendly ping
8 years, 4 months ago (2012-08-14 11:11:55 UTC) #2
Roman
8 years, 4 months ago (2012-08-14 11:21:01 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698