Issue 10855101: RemoveFromGraph on definitions asserts empty use lists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855101: RemoveFromGraph on definitions asserts empty use lists. (Closed)

Created:
8 years, 4 months ago by zerny-google

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

RemoveFromGraph on definitions asserts empty use lists. R=fschneider@google.com,kmillikin@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10822

Patch Set 2 : Added default value for argument. #

Total comments: 1

Patch Set 3 : Corrected invariants of def-use chains. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -7 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	3 chunks	+14 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	1 chunk	+8 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://chromiumcodereview.appspot.com/10855101/diff/3001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10855101/diff/3001/runtime/vm/intermediate_language.cc#newcode146 runtime/vm/intermediate_language.cc:146: ASSERT(use_list() == NULL); Alternatively, you could put the ...

8 years, 4 months ago (2012-08-13 08:37:37 UTC) #2

zerny-google

8 years, 4 months ago (2012-08-15 11:17:06 UTC) #3

Updated the patch set to correctly maintain the invariants, except when removing
pushed arguments. Here we null the use list and let the allocater repair the
environments (ie, unchanged from before).