Added support for multi-valued options (options that can occur more than once).

Added support for multi-valued options (options that can occur more than once).
Committed: https://code.google.com/p/dart/source/detail?r=10477

[gram, 2012-08-09 21:55:48]

I dropped the idea of allowing comma-separated multi-values. I have mixed
feelings about that - my concern is if we wanted to specify a value that
contains a comma, we then have to start dealing with quoted/escaped arguments,
which is a whole lot of cost for little benefit. So for now you have to specify
the option multiple times.

[Bob Nystrom, 2012-08-09 23:08:39]

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart
File lib/args/args.dart (right):

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:129: * List of values will be returned.
You should show an example of this.

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:222: void callback(bool value), bool multiValued]) {
How about:

"multiValued" -> "allowMultiple"

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:268: results[name] = new List();
'new List()' => '[]'

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:334: if (option.multiValued) {
Nit, but can you add a blank line above this? I tend to put blank lines between
successive block body statements.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
File tests/lib/args/args_test.dart (right):

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:361: test('return last set value', () {
"return" -> "returns"
"set" -> "provided"

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:368: test('return List if multi-valued', () {
"return List" -> "returns a List"

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:370: parser.addOption('define', multiValued:true);
Space after ":" here and elsewhere.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:372: expect(args['define'], hasLength(1));
Can you just do this:

expect(args['define'], equals([1])));

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:376: expect(args['define'][1], equals('2'));
Ditto here. equals() handles lists, right?

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:379: test('default values for multi-valued
arguments', () {
This should be worded like a predicate. Maybe "returns the default value for a
multi-argument if not set"

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:590: expect(function,
throwsIllegalArgumentException);
+1!

[gram, 2012-08-09 23:47:00]

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart
File lib/args/args.dart (right):

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:129: * List of values will be returned.
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> You should show an example of this.

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:222: void callback(bool value), bool multiValued]) {
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> How about:
> 
> "multiValued" -> "allowMultiple"

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:268: results[name] = new List();
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> 'new List()' => '[]'

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/lib/args/args.dart#...
lib/args/args.dart:334: if (option.multiValued) {
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> Nit, but can you add a blank line above this? I tend to put blank lines
between
> successive block body statements.

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
File tests/lib/args/args_test.dart (right):

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:361: test('return last set value', () {
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> "return" -> "returns"
> "set" -> "provided"

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:368: test('return List if multi-valued', () {
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> "return List" -> "returns a List"

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:370: parser.addOption('define', multiValued:true);
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> Space after ":" here and elsewhere.

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:372: expect(args['define'], hasLength(1));
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> Can you just do this:
> 
> expect(args['define'], equals([1])));

Done.

https://chromiumcodereview.appspot.com/10855084/diff/5002/tests/lib/args/args...
tests/lib/args/args_test.dart:376: expect(args['define'][1], equals('2'));
On 2012/08/09 23:08:40, Bob Nystrom wrote:
> Ditto here. equals() handles lists, right?

Done.

[Bob Nystrom, 2012-08-10 00:35:39]

LGTM! Thanks for doing this!