Issue 10855053: Align AllocateObjectComp and AllocateObjectWithBoundsCheckComp with ssa allocator.

Issue 10855053: Align AllocateObjectComp and AllocateObjectWithBoundsCheckComp with ssa allocator. (Closed)

Created:
8 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Align AllocateObjectComp and AllocateObjectWithBoundsCheckComp with ssa allocator. AllocateObjectComp becomes a call computation with all arguments pushed via PushArgument. AllocateObjectWithBoundsCheckComp pushes inputs internally. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10453

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -57 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	5 chunks	+50 lines, -15 lines	2 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	4 chunks	+19 lines, -24 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

https://chromiumcodereview.appspot.com/10855053/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/10855053/diff/1/runtime/vm/flow_graph_builder.cc#newcode1641 runtime/vm/flow_graph_builder.cc:1641: ZoneGrowableArray<PushArgumentInstr*>* call_arguments) { This function became a little bit ...

8 years, 4 months ago (2012-08-08 19:28:55 UTC) #2

Florian Schneider

8 years, 4 months ago (2012-08-09 12:25:58 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/10855053/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10855053/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:1641: ZoneGrowableArray<PushArgumentInstr*>*
call_arguments) {
On 2012/08/08 19:28:55, Vyacheslav Egorov (Google) wrote:
> This function became a little bit ugly.
> 
> I did not find any good way to share it properly because PushArgument should
be
> interleaved with Binds

Yes, it seems that this helper is not the right abstraction. We should keep in
mind cleaning it up at a later point.

Expand Messages | Collapse Messages