Issue 10855050: Reapply and fix "Remove duplicate code for smi and double comparison from the compiler.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855050: Reapply and fix "Remove duplicate code for smi and double comparison from the compiler.". (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Reapply and fix "Remove duplicate code for smi and double comparison from the compiler.". The bug fix was to always allocate the correct number of temp registers on x64. Committed: https://code.google.com/p/dart/source/detail?r=10384

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -191 lines)			Patch
	M	vm/intermediate_language_ia32.cc	View		3 chunks	+41 lines, -94 lines	0 comments	Download
	M	vm/intermediate_language_x64.cc	View		4 chunks	+43 lines, -97 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages