Issue 10855026: Don't rely on the existence of an element in field gets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855026: Don't rely on the existence of an element in field gets. (Closed)

Created:
8 years, 4 months ago by floitsch

Modified:
8 years, 4 months ago

Reviewers:
Søren Gjesse, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Don't rely on the existence of an element in field gets. Committed: https://code.google.com/p/dart/source/detail?r=10417

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -29 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	3 chunks	+38 lines, -22 lines	0 comments	Download
	M	lib/compiler/implementation/ssa/optimize.dart	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

floitsch

On 2012/08/08 06:56:18, kasperl wrote: > LGTM. Do you have a regression test case? No. ...

8 years, 4 months ago (2012-08-08 07:15:42 UTC) #3

floitsch

Found some other cases. PTAL. It is currently not possible to test the changes, because ...

8 years, 4 months ago (2012-08-08 14:34:05 UTC) #4

lgtm