Issue 10855019: Add a function's initial stack check to the IL instruction stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855019: Add a function's initial stack check to the IL instruction stream. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a function's initial stack check to the IL instruction stream. This stack check needs a GC safepoint. It is simplest to implement that by exposing it as an explicit instruction. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10338

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -24 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	5 chunks	+4 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	5 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This change (temporarily) adds a stack check to leaf routines that was previously skipped. I'll ...

8 years, 4 months ago (2012-08-07 11:03:03 UTC) #1

srdjan

8 years, 4 months ago (2012-08-07 19:04:30 UTC) #3

DBC

https://chromiumcodereview.appspot.com/10855019/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10855019/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:2302: // stack check on entry for leaf
routines).
Yes. Why not skip it if IsLeaf()?

Expand Messages | Collapse Messages