Issue 10854232: Continue removal of frog.

Issue 10854232: Continue removal of frog. (Closed)

Created:
8 years, 4 months ago by dgrove

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom, ahe

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Continue removal of frog. Committed: https://code.google.com/p/dart/source/detail?r=10996

Patch Set 1 #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -62 lines)			Patch
M	tools/create_sdk.py	View	1 chunk	+2 lines, -2 lines	4 comments	Download
M	tools/presubmit.sh	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	tools/test-runtime.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_options.dart	View	4 chunks	+5 lines, -21 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	6 chunks	+1 line, -24 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM Once again: Thank you for keeping it tidy, Dan! Cheers, Peter https://chromiumcodereview.appspot.com/10854232/diff/1/tools/create_sdk.py File tools/create_sdk.py ...

8 years, 4 months ago (2012-08-20 19:33:27 UTC) #3

dgrove

https://chromiumcodereview.appspot.com/10854232/diff/1/tools/create_sdk.py File tools/create_sdk.py (right): https://chromiumcodereview.appspot.com/10854232/diff/1/tools/create_sdk.py#newcode40 tools/create_sdk.py:40: # ........dart2js/ On 2012/08/20 19:33:27, ahe wrote: > Is ...

8 years, 4 months ago (2012-08-20 19:35:33 UTC) #4

ahe

8 years, 4 months ago (2012-08-20 19:39:28 UTC) #5

dgrove

8 years, 4 months ago (2012-08-20 20:25:03 UTC) #6

https://chromiumcodereview.appspot.com/10854232/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://chromiumcodereview.appspot.com/10854232/diff/1/tools/create_sdk.py#ne...
tools/create_sdk.py:40: # ........dart2js/
I haven't made any changes in where dart2js is picking up its libs in the SDK,
but I'm hoping to make those changes as soon as corelib is untangled.

This directory has been there for quite awhile - I'm just updating the comment
to reflect the current reality.
On 2012/08/20 19:39:28, ahe wrote:
> On 2012/08/20 19:35:33, dgrove wrote:
> > On 2012/08/20 19:33:27, ahe wrote:
> > > Is this true?
> > 
> > Yes. dart-sdk/lib/isolate/dart2js/ contains
> > compiler_hooks.dart     isolateimpl.dart        messages.dart          
> > ports.dart              timer_provider.dart
> > 
> 
> I don't think dart2js reads those files. Unless you changed it, dart2js reads
> the version in dart-sdk/lib/dart2js/lib/isolate/dart2js.

Expand Messages | Collapse Messages