Sort the Dart vm flags before printing them out with the --print-flags option.

Sort the Dart vm flags before printing them out with the --print-flags option.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11031

[Bill Hesse, 2012-08-20 15:26:40]

platform/globals.h includes stdlib.h for non-Windows - I haven't tried on
Windows yet.

[Ivan Posva, 2012-08-20 23:50:35]

LGTM -ip

https://chromiumcodereview.appspot.com/10854224/diff/1/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

https://chromiumcodereview.appspot.com/10854224/diff/1/runtime/vm/flags.cc#ne...
runtime/vm/flags.cc:322: num_flags++;
You could increment this as part of registration of flags and keep it around
with the rest of the flags. Although I am not sure of the usefulness of the
count beyond PrintFlags.

https://chromiumcodereview.appspot.com/10854224/diff/1/runtime/vm/flags.cc#ne...
runtime/vm/flags.cc:328: while (flag != NULL) {
for (int i = 0; i <  num_flags; i++) {
  ASSERT(flag != NULL);
  flag_array[i] = flag;
  flag = flag->next_;
}
ASSERT(flag = NULL);

To be consistent with the other loop going over the flags array.
You could also put the flag = flag->next_ into the for-loop. I am not a big fan
of multiple things happening there, but in this case it almost makes sense.

[Bill Hesse, 2012-08-21 09:21:01]

If we ever wanted a different, thematic sort, we can easily add a sort key to
the flag structure.

https://chromiumcodereview.appspot.com/10854224/diff/1/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

https://chromiumcodereview.appspot.com/10854224/diff/1/runtime/vm/flags.cc#ne...
runtime/vm/flags.cc:328: while (flag != NULL) {
On 2012/08/20 23:50:35, Ivan Posva wrote:
> for (int i = 0; i <  num_flags; i++) {
>   ASSERT(flag != NULL);
>   flag_array[i] = flag;
>   flag = flag->next_;
> }
> ASSERT(flag = NULL);
> 
> To be consistent with the other loop going over the flags array.
> You could also put the flag = flag->next_ into the for-loop. I am not a big
fan
> of multiple things happening there, but in this case it almost makes sense.

Done.

[Bill Hesse, 2012-08-21 11:01:28]

Tested on Windows - it compiles and works with no errors.