Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 10854218: dart2dart Collect type placeholder for default class. (Closed)

Created:
8 years, 4 months ago by Roman
Modified:
8 years, 4 months ago
Reviewers:
Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2dart Collect type placeholder for default class. Committed: https://code.google.com/p/dart/source/detail?r=10967

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M lib/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 3 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roman
8 years, 4 months ago (2012-08-20 12:50:04 UTC) #1
Anton Muhin
lgtm, but, please, add a test
8 years, 4 months ago (2012-08-20 12:53:34 UTC) #2
Roman
Done.
8 years, 4 months ago (2012-08-20 13:57:52 UTC) #3
Anton Muhin
8 years, 4 months ago (2012-08-20 13:58:42 UTC) #4
Thank you very much!  Still LGTM

Powered by Google App Engine
This is Rietveld 408576698