Require two type arguments for map literals (issue 4522).

Require two type arguments for map literals (issue 4522).
Spec has been changed back.
VM temporarily accepts a single type argument and emits a warning.
Update tests, dart2js source, dartdoc, etc...
Disable failing co19 tests (issue 175 filed).
Committed: https://code.google.com/p/dart/source/detail?r=10861

[ahe, 2012-08-16 19:52:48]

Hi Regis,

Thank you for cleaning this up!

Changes to lib/compiler and tests/, LGTM.

Please make sure that you don't break utils/dummy_compiler_test (this is dart2js
compiling itself). I have described how to run this test at the end of this
page: http://code.google.com/p/dart/wiki/TestingDart2js

Cheers,
Peter

https://chromiumcodereview.appspot.com/10854191/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/partial_parser.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/partial_parser.dart:44: //   Foo() : map =
<String, Foo>{};
Nice catch :-)

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
File tests/language/map_literal2_negative_test.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
tests/language/map_literal2_negative_test.dart:11: var m = const <String,
T>{"a": 0};  // Type parameter is not allowed with const.
Long line.

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
File tests/language/map_literal3_test.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
tests/language/map_literal3_test.dart:64: final cmap = const <String, num>{"a":
10, "b": 100, "a": 1000}; /// static type warning
Several long lines

[hausner, 2012-08-16 20:02:38]

LGTM w/comment

https://chromiumcodereview.appspot.com/10854191/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:8073: Warning(type_pos,
As Peter notes, I would guard this with a separate flag, eg.
--warn_illegal_map_args or something.

[regis, 2012-08-16 20:11:00]

Thanks!

https://chromiumcodereview.appspot.com/10854191/diff/1/lib/compiler/implement...
File lib/compiler/implementation/scanner/partial_parser.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/lib/compiler/implement...
lib/compiler/implementation/scanner/partial_parser.dart:44: //   Foo() : map =
<String, Foo>{};
On 2012/08/16 19:52:49, ahe wrote:
> Nice catch :-)

Thanks :-)
There were a few more...

https://chromiumcodereview.appspot.com/10854191/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/runtime/vm/parser.cc#n...
runtime/vm/parser.cc:8073: Warning(type_pos,
On 2012/08/16 20:02:39, hausner wrote:
> As Peter notes, I would guard this with a separate flag, eg.
> --warn_illegal_map_args or something.

Done. I have hidden the warning behind --warn_legacy_syntax, renamed from
--warn_legacy_catch_syntax.

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
File tests/language/map_literal2_negative_test.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
tests/language/map_literal2_negative_test.dart:11: var m = const <String,
T>{"a": 0};  // Type parameter is not allowed with const.
On 2012/08/16 19:52:49, ahe wrote:
> Long line.

Done.

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
File tests/language/map_literal3_test.dart (right):

https://chromiumcodereview.appspot.com/10854191/diff/1/tests/language/map_lit...
tests/language/map_literal3_test.dart:64: final cmap = const <String, num>{"a":
10, "b": 100, "a": 1000}; /// static type warning
On 2012/08/16 19:52:49, ahe wrote:
> Several long lines

I do not want to disrupt the special meaning of the /// with a line break. We
have plenty of other occurrences of long lines with ///.

[Bob Nystrom, 2012-08-16 21:41:23]

Showing up a little late to the party, but dartdoc, pub, and yaml changes all
LGTM!