Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1944)

Issue 10854176: - Merge function lists when patching classes (no more duplicates). (Closed)

Created:
8 years, 4 months ago by Ivan Posva
Modified:
8 years, 4 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, Mads Ager (google), Anders Johnsen
Visibility:
Public.

Description

- Merge function lists when patching classes (no more duplicates). - Report errors when applying a patch with duplicate fields or mismatched parameters. - Fix bug 4526: Wrong error message when defining an already defined class. Committed: https://code.google.com/p/dart/source/detail?r=10784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -34 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +59 lines, -30 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
8 years, 4 months ago (2012-08-15 23:10:31 UTC) #1
hausner
Looks correct to me.
8 years, 4 months ago (2012-08-15 23:46:10 UTC) #2
siva
lgtm. Mathias, it looks politically correct or logically correct?
8 years, 4 months ago (2012-08-15 23:49:58 UTC) #3
hausner
8 years, 4 months ago (2012-08-15 23:58:53 UTC) #4
In a Rube Goldberg kind of way it looks to me as if it does the trick :)

Powered by Google App Engine
This is Rietveld 408576698