Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 10854156: Add a support for a slow marker in status files. (Closed)

Created:
8 years, 4 months ago by ricow1
Modified:
8 years, 4 months ago
Reviewers:
ahe, Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a support for a slow marker in status files. The reasoning for this is that we want to have a sufficiently low timeout to catch performance regressions, but still want to maintain the support for having a few tests that takes a longer time to complete. This cl adds 2 slow functions, I will add more if any additional tests timeout on the buildbot. Committed: https://code.google.com/p/dart/source/detail?r=10714

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M tests/co19/co19-dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M tools/testing/dart/test_options.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 2 chunks +8 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
ricow1
8 years, 4 months ago (2012-08-15 11:29:31 UTC) #1
ahe
LGTM, but please have Bill take a look before submitting.
8 years, 4 months ago (2012-08-15 11:34:13 UTC) #2
Bill Hesse
8 years, 4 months ago (2012-08-15 11:41:03 UTC) #3
LGTM.

https://chromiumcodereview.appspot.com/10854156/diff/1/tools/testing/dart/tes...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/10854156/diff/1/tools/testing/dart/tes...
tools/testing/dart/test_runner.dart:135: 
How about 
  if (expectedOutcomes.contains(SLOW)) {
    return SLOW_TIMEOUT_MULTIPLIER * configuration['timeout'];
} else {
  return configuration['timeout'];
}
or even 
 => expectedOutcomes.contains(SLOW) ?
   ... :
   ... ;

Powered by Google App Engine
This is Rietveld 408576698