Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 10854036: Fix gyp settings for builds within Visual Studio. (Closed)

Created:
8 years, 4 months ago by ricow1
Modified:
8 years, 4 months ago
Reviewers:
Søren Gjesse, ahe
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Fix gyp settings for builds within Visual Studio. This is landing of a community patch from Don J. Olmstead, see: http://code.google.com/p/dart/issues/detail?id=4296 Committed: https://code.google.com/p/dart/source/detail?r=10366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
8 years, 4 months ago (2012-08-08 07:23:47 UTC) #1
ricow1
CC'ing Peter
8 years, 4 months ago (2012-08-08 07:24:43 UTC) #2
Søren Gjesse
LGTM, but should we mention the author in the commit message?
8 years, 4 months ago (2012-08-08 07:44:13 UTC) #3
ricow1
Yes, we should, added his name to the cl description
8 years, 4 months ago (2012-08-08 07:49:17 UTC) #4
ahe
8 years, 4 months ago (2012-08-21 19:54:12 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698