Issue 10854025: Fix dartdoc block code comments in Dart API that are broken and use [: :] delimiters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854025: Fix dartdoc block code comments in Dart API that are broken and use [: :] delimiters. (Closed)

Created:
8 years, 4 months ago by Bill Hesse

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dartdoc block code comments in Dart API that are broken and use [: :] delimiters. BUG=dart:2570 Committed: https://code.google.com/p/dart/source/detail?r=10368

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -46 lines)			Patch
M	corelib/src/expect.dart	View	1	5 chunks	+10 lines, -13 lines	0 comments	Download
M	corelib/src/regexp.dart	View		3 chunks	+14 lines, -20 lines	0 comments	Download
M	runtime/bin/input_stream.dart	View		3 chunks	+11 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

I grepped for all the [: that showed up in the final HTML, and fixed ...

8 years, 4 months ago (2012-08-07 14:45:13 UTC) #1

Bob Nystrom

8 years, 4 months ago (2012-08-07 17:19:02 UTC) #2

Beautiful, I love it! LGTM!

http://chromiumcodereview.appspot.com/10854025/diff/1/corelib/src/expect.dart
File corelib/src/expect.dart (right):

http://chromiumcodereview.appspot.com/10854025/diff/1/corelib/src/expect.dart...
corelib/src/expect.dart:261: *     Expect.throws(myThrowingFunction, (e) {
return e is MyException; })
Unrelated, but we could use an "=>" function in this example.

Expand Messages | Collapse Messages