Issue 10853009: Move hashmap.h and hashmap.cc from the 'bin' directory to 'platform' directory so that it can be us…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10853009: Move hashmap.h and hashmap.cc from the 'bin' directory to 'platform' directory so that it can be us… (Closed)

Created:
8 years, 4 months ago by siva

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Move hashmap.h and hashmap.cc from the 'bin' directory to 'platform' directory so that it can be used from VM code too. Committed: https://code.google.com/p/dart/source/detail?r=10261

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -277 lines)			Patch
M	bin/builtin_impl_sources.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	bin/eventhandler_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bin/eventhandler_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bin/eventhandler_macos.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	bin/eventhandler_macos.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	bin/hashmap.h	View	1 chunk	+0 lines, -76 lines	0 comments	Download
D	bin/hashmap.cc	View	1 chunk	+0 lines, -190 lines	0 comments	Download
M	bin/hashmap_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	platform/hashmap.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	platform/hashmap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	platform/platform_headers.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	platform/platform_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

siva

8 years, 4 months ago (2012-08-03 22:10:55 UTC) #1

This change was already reviewed in another CL, I had to recreate the CL and
submit.

Moving looks good to me. I guess some cleanup to follow.

-Ivan