Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10850017: Revert "Use platform-independent format specifiers when disassembling code objects." (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)
Modified:
8 years, 4 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Use platform-independent format specifiers when disassembling code objects." Revert svn revision 10163 while working on a Windows fix. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/platform/globals.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +28 lines, -22 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
8 years, 4 months ago (2012-08-02 13:50:39 UTC) #1
Kevin Millikin (Google)
TBR'd.
8 years, 4 months ago (2012-08-02 13:51:40 UTC) #2
Mads Ager (google)
8 years, 4 months ago (2012-08-02 13:53:32 UTC) #3
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698