Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 10850015: Changed default Uri constructor to Uri.fromComponents(), new default constructor is Uri.fromString(… (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed default Uri constructor to Uri.fromComponents(), new default constructor is Uri.fromString(). This is to avoid new Uri('http://www.google.com') resulting in Uri with scheme='http://www.google.com'. Committing on behalf of: Alexander Aprelev <aprelev@gmail.com>; BUG=dart-3348 TEST=new Uri('http://www.google.com') is the same as new Uri.fromString('http://www.google.com') same as new Uri.fromComponents(scheme:'http', domain:'www.google.com') Committed: https://code.google.com/p/dart/source/detail?r=10168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -53 lines) Patch
M dart/lib/compiler/implementation/filenames.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/lib/uri/uri.dart View 2 chunks +18 lines, -14 lines 0 comments Download
M dart/runtime/bin/builtin.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/mock_compiler.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/parser_helper.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/source_mapping_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/unparser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/utils/dummy_compiler_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/utils/uri_test.dart View 3 chunks +38 lines, -26 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698