Issue 10850014: Separate double binary operation into a separate instruction class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10850014: Separate double binary operation into a separate instruction class. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Separate double binary operation into a separate instruction class. Double operation are currently implemented as calls, so they need arguments pushed on the stack. Smi and Mint operations are not calls, so they are handled with the same instruction as before. Committed: https://code.google.com/p/dart/source/detail?r=10178

Patch Set 1 #

Patch Set 2 : added ia32 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -80 lines)			Patch
M	vm/flow_graph_optimizer.cc	View		1 chunk	+17 lines, -11 lines	0 comments	Download
M	vm/il_printer.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	vm/intermediate_language.h	View		7 chunks	+31 lines, -5 lines	0 comments	Download
M	vm/intermediate_language.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	vm/intermediate_language_ia32.cc	View	1	5 chunks	+31 lines, -32 lines	0 comments	Download
M	vm/intermediate_language_x64.cc	View		5 chunks	+31 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages