Issue 10843053: Improve the error message for handle check failure to list the actual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843053: Improve the error message for handle check failure to list the actual (Closed)

Created:
8 years, 4 months ago by turnidge

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Improve the error message for handle check failure to list the actual and expected types: error: Handle check failed: saw <whatever> expected <whatever> Committed: https://code.google.com/p/dart/source/detail?r=10253

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	vm/object.h	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 4 months ago (2012-08-03 20:13:10 UTC) #3

https://chromiumcodereview.appspot.com/10843053/diff/1/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10843053/diff/1/vm/object.h#newcode66
vm/object.h:66: obj->GetClassName(), #object);                                  
 \
What would happen if you used ToCString() here, instead of adding
GetClassName()?

Expand Messages | Collapse Messages