Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 10843040: translate uris pointing to non-existing dart libraries (Closed)

Created:
8 years, 4 months ago by danrubel
Modified:
8 years, 4 months ago
Reviewers:
scheglov, keertip
CC:
reviews_dartlang.org
Visibility:
Public.

Description

translate uris pointing to non-existing dart libraries Committed: https://code.google.com/p/dart/source/detail?r=10153

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M compiler/java/com/google/dart/compiler/SystemLibraryManager.java View 1 chunk +6 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/SystemLibraryManagerTest.java View 1 3 chunks +19 lines, -22 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/test/util/DartCoreTestLog.java View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
* improve SystemLibraryManager#translateDartUri(…) to handle uri's pointing to non-existing dart libraries * echo remaining test ...
8 years, 4 months ago (2012-08-02 01:50:43 UTC) #1
scheglov
lgtm
8 years, 4 months ago (2012-08-02 01:59:04 UTC) #2
danrubel
Moved test from ContextTest class into SystemLibraryManagerTest
8 years, 4 months ago (2012-08-02 03:29:37 UTC) #3
keertip
8 years, 4 months ago (2012-08-02 15:39:03 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698