Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 10843028: Update standalone.status file - my previous commit fixed two tests. (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update standalone.status file - my previous commit fixed two tests. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tests/standalone/standalone.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
8 years, 4 months ago (2012-08-01 14:02:42 UTC) #1
Mads Ager (google)
LGTM, I guess the mock implementation can deal with something now that it couldn't before?
8 years, 4 months ago (2012-08-01 14:04:06 UTC) #2
Anders Johnsen
8 years, 4 months ago (2012-08-01 14:05:07 UTC) #3
Yes, I lowered a restriction (requiring int, when it could be a double (large js
number)), that Peter pointed out for me.

Powered by Google App Engine
This is Rietveld 408576698