Issue 10843022: Partially rollback noSuchMethod for UnknownElement until we figure out code size issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843022: Partially rollback noSuchMethod for UnknownElement until we figure out code size issue (Closed)

Created:
8 years, 4 months ago by vsm

Modified:
8 years, 4 months ago

Reviewers:
Jacob, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Partially rollback noSuchMethod for UnknownElement until we figure out code size issue jacob: This won't effect Dartium. Just rolling back for dart2js, which wasn't working anyway. Committed: https://code.google.com/p/dart/source/detail?r=10118

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	lib/dom/templates/html/impl/impl_UnknownElement.darttemplate	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

I've verified that this reduces generated swarm size back to what it was before r9839.

8 years, 4 months ago (2012-08-01 04:20:56 UTC) #2

LGTM! Thank you, Vijay.

Expand Messages | Collapse Messages