Issue 10843007: Cleanup isolate library after frog removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10843007: Cleanup isolate library after frog removal. (Closed)

Created:
8 years, 4 months ago by Mads Ager (google)

Modified:
8 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang), kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup isolate library after frog removal. Remove parts only used by frog and rename. R=kasperl@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10051

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1300 lines)			Patch
M	lib/compiler/implementation/library_map.dart	View	1 chunk	+5 lines, -9 lines	0 comments	Download
A +	lib/isolate/dart2js/compiler_hooks.dart	View	1 chunk	+6 lines, -5 lines	0 comments	Download
A +	lib/isolate/dart2js/isolateimpl.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/isolate/dart2js/messages.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	lib/isolate/dart2js/ports.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	lib/isolate/frog/compiler_hooks.dart	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	lib/isolate/frog/isolateimpl.dart	View	1 chunk	+0 lines, -646 lines	0 comments	Download
D	lib/isolate/frog/messages.dart	View	1 chunk	+0 lines, -164 lines	0 comments	Download
D	lib/isolate/frog/natives.js	View	1 chunk	+0 lines, -78 lines	1 comment	Download
D	lib/isolate/frog/ports.dart	View	1 chunk	+0 lines, -253 lines	0 comments	Download
M	lib/isolate/isolate_compiler.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
A +	lib/isolate/isolate_dart2js.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	lib/isolate/isolate_frog.dart	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	lib/isolate/isolate_leg.dart	View	1 chunk	+0 lines, -61 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 4 months ago (2012-08-01 21:17:29 UTC) #3

https://chromiumcodereview.appspot.com/10843007/diff/1/lib/isolate/frog/nativ...
File lib/isolate/frog/natives.js (left):

https://chromiumcodereview.appspot.com/10843007/diff/1/lib/isolate/frog/nativ...
lib/isolate/frog/natives.js:12: var $supportsWorkers =
please note: the current code for isolates in dart2js is not working correctly:
spawnFunction should spawn an isolate in a worker, and it's currently spawning
the new isolate in the DOM UI thread.

This bug is because we are not including some of the initialization of this file
in the dart2js generated code.

Expand Messages | Collapse Messages