Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 10840004: Update test to work with lazy compilation (Closed)

Created:
8 years, 4 months ago by ahe
Modified:
8 years, 4 months ago
Reviewers:
floitsch, kasperl
CC:
reviews_dartlang.org, hausner
Visibility:
Public.

Description

Update test to work with lazy compilation Committed: https://code.google.com/p/dart/source/detail?r=11061

Patch Set 1 #

Patch Set 2 : Tweaked test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M dart/tests/language/final_syntax_test.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
8 years, 4 months ago (2012-08-15 17:23:46 UTC) #1
kasperl
LGTM.
8 years, 4 months ago (2012-08-15 17:27:22 UTC) #2
floitsch
LGTM, but you will need to update the status files.
8 years, 4 months ago (2012-08-15 18:12:23 UTC) #3
ahe
8 years, 4 months ago (2012-08-21 15:28:16 UTC) #4
I tweaked the test because I noticed that dart2js was passing it for the wrong
reason. I'm submitting now, but please look at the second patch set.

Powered by Google App Engine
This is Rietveld 408576698