Language tests updated to use const instead of final.

Language tests updated to use const instead of final.

Committed: https://code.google.com/p/dart/source/detail?r=11165

[ahe, 2012-08-21 13:08:07]

I really don't like saying this, but it looks like we should keep "final" on all
instance fields and local variables.

[Johnni Winther, 2012-08-21 13:42:37]

PTAL

[ahe, 2012-08-22 10:14:45]

LGTM!

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/lang...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/lang...
tests/language/language_dart2js.status:55: adjacent_const_string_literals_test:
Fail
Please copy the comment so each line looks like:

call_through_getter_test: Fail # const variables are not regarded as
compile-time constants.

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
File tests/language/static_top_level_test.dart (right):

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
tests/language/static_top_level_test.dart:7: static const constant = 42;        
 /// 02: compile-time error
I think you need to duplicate this test. One for final and one for const.

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
tests/language/static_top_level_test.dart:11: static const int typedConstant =
99; /// 05: compile-time error
And this.

[Johnni Winther, 2012-08-22 15:35:43]

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/lang...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/lang...
tests/language/language_dart2js.status:55: adjacent_const_string_literals_test:
Fail
On 2012/08/22 10:14:45, ahe wrote:
> Please copy the comment so each line looks like:
> 
> call_through_getter_test: Fail # const variables are not regarded as
> compile-time constants.

Ignored, since it will be removed by the next CL.

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
File tests/language/static_top_level_test.dart (right):

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
tests/language/static_top_level_test.dart:7: static const constant = 42;        
 /// 02: compile-time error
On 2012/08/22 10:14:45, ahe wrote:
> I think you need to duplicate this test. One for final and one for const.

Done.

https://chromiumcodereview.appspot.com/10837359/diff/3001/tests/language/stat...
tests/language/static_top_level_test.dart:11: static const int typedConstant =
99; /// 05: compile-time error
On 2012/08/22 10:14:45, ahe wrote:
> And this.

Done.

[kasperl, 2012-08-23 05:16:59]

Thanks, Johnni. This definitely improved the test coverage for const!