Split collecting and traversing.

Split collecting and traversing.

R=smok@google.com

Committed: https://code.google.com/p/dart/source/detail?r=10985

[Roman, 2012-08-17 08:22:28]

lgtm

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:108: if (element is
ClassElement) {
I would prefer that class members are explicitly collected below, after we
collect top level elements, like:
classMembers.getValues().forEach(makePlaceholders);

I think it's cleaner.

[Anton Muhin, 2012-08-17 08:32:41]

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:108: if (element is
ClassElement) {
I actually started that way, but decided eventually against it.  The idea is in
contrast to the previous approach, classElement to members mapping is now not
that important, the key data is a collection of top level.

As an experiment (it might be worth experimenting): we can probably omit
classMemebers altogether with the following trick: when emitting class, for each
member to be emitted, check if it got into resolvedElements.

On 2012/08/17 08:22:28, Roman wrote:
> I would prefer that class members are explicitly collected below, after we
> collect top level elements, like:
> classMembers.getValues().forEach(makePlaceholders);
> 
> I think it's cleaner.

[Roman, 2012-08-17 08:34:24]

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:108: if (element is
ClassElement) {
On 2012/08/17 08:32:41, Anton Muhin wrote:
> I actually started that way, but decided eventually against it.  The idea is
in
> contrast to the previous approach, classElement to members mapping is now not
> that important, the key data is a collection of top level.
> 
> As an experiment (it might be worth experimenting): we can probably omit
> classMemebers altogether with the following trick: when emitting class, for
each
> member to be emitted, check if it got into resolvedElements.
> 
> On 2012/08/17 08:22:28, Roman wrote:
> > I would prefer that class members are explicitly collected below, after we
> > collect top level elements, like:
> > classMembers.getValues().forEach(makePlaceholders);
> > 
> > I think it's cleaner.
> 

Probably I'm wrong, but I think that some element gets into class's members only
when it is used, e.g. resolved.

[Anton Muhin, 2012-08-17 08:38:04]

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10837289/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:108: if (element is
ClassElement) {
Yes.

Now we go over all the member elements and put them in the map.

We could have done differently: when class is used, go over all its members and
check if they are resolved i.e. used.

On 2012/08/17 08:34:24, Roman wrote:
> On 2012/08/17 08:32:41, Anton Muhin wrote:
> > I actually started that way, but decided eventually against it.  The idea is
> in
> > contrast to the previous approach, classElement to members mapping is now
not
> > that important, the key data is a collection of top level.
> > 
> > As an experiment (it might be worth experimenting): we can probably omit
> > classMemebers altogether with the following trick: when emitting class, for
> each
> > member to be emitted, check if it got into resolvedElements.
> > 
> > On 2012/08/17 08:22:28, Roman wrote:
> > > I would prefer that class members are explicitly collected below, after we
> > > collect top level elements, like:
> > > classMembers.getValues().forEach(makePlaceholders);
> > > 
> > > I think it's cleaner.
> > 
> 
> Probably I'm wrong, but I think that some element gets into class's members
only
> when it is used, e.g. resolved.