Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 10837286: Support new optional parameter syntax (issue 4289) (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson
Modified:
8 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support new optional parameter syntax (issue 4289) Committed: https://code.google.com/p/dart/source/detail?r=10832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -19 lines) Patch
M compiler/java/com/google/dart/compiler/ast/Modifiers.java View 4 chunks +5 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 6 chunks +70 lines, -16 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java View 3 chunks +5 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
8 years, 4 months ago (2012-08-16 15:58:26 UTC) #1
scheglov
LGTM Does it work when all - formal, optional and named parameters declared?
8 years, 4 months ago (2012-08-16 16:30:58 UTC) #2
Brian Wilkerson
8 years, 4 months ago (2012-08-16 16:38:14 UTC) #3
> Does it work when all - formal, optional and named parameters declared?

It isn't possible to have both optional and named parameters in the same
parameter list.

formalParameterList:     
      '(' ')' 
    | '(' normalFormalParameters ( ‘,’ optionalFormalParameters)? ')'
    | '(' optionalFormalParameters ')'
    ;

optionalFormalParameters:
     optionalPositionalFormalParameters |
     namedFormalParameters
    ;

Powered by Google App Engine
This is Rietveld 408576698