Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10837274: Allow `pub install` and `pub update` to update dependers. (Closed)

Created:
8 years, 4 months ago by nweiz
Modified:
8 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow `pub install` and `pub update` to update dependers. If the pubspec has a new dependency which causes an incompatibility with the locked packages' version constraints, `pub install` will now unlock packages one by one until a compatible version graph can be found. `pub update <package>` will now always update the given package to its latest version, even if that requires updating locked packages that depend on it transitively. If no amount of updating will make the latest version valid, an exception will be thrown. This was originally submitted as r10779 Committed: https://code.google.com/p/dart/source/detail?r=11119

Patch Set 1 #

Patch Set 2 : Merge master #

Patch Set 3 : Fix VersionSolver test failures. #

Total comments: 4

Patch Set 4 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -37 lines) Patch
M utils/pub/entrypoint.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M utils/pub/version_solver.dart View 1 2 3 11 chunks +157 lines, -31 lines 0 comments Download
M utils/tests/pub/pub_test.dart View 1 2 chunks +358 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
This is the same as r10779 except for patch set 2.
8 years, 4 months ago (2012-08-21 18:26:46 UTC) #1
Bob Nystrom
Just reviewed patch set 2. https://chromiumcodereview.appspot.com/10837274/diff/3004/utils/pub/version_solver.dart File utils/pub/version_solver.dart (right): https://chromiumcodereview.appspot.com/10837274/diff/3004/utils/pub/version_solver.dart#newcode331 utils/pub/version_solver.dart:331: Dependency dependency, VersionConstraint oldConstraint) ...
8 years, 4 months ago (2012-08-21 18:29:57 UTC) #2
nweiz
https://chromiumcodereview.appspot.com/10837274/diff/3004/utils/pub/version_solver.dart File utils/pub/version_solver.dart (right): https://chromiumcodereview.appspot.com/10837274/diff/3004/utils/pub/version_solver.dart#newcode331 utils/pub/version_solver.dart:331: Dependency dependency, VersionConstraint oldConstraint) { On 2012/08/21 18:29:57, Bob ...
8 years, 4 months ago (2012-08-21 19:57:23 UTC) #3
Bob Nystrom
8 years, 4 months ago (2012-08-21 21:01:04 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698