Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 10837208: Support new getter syntax (no formal parameter list) (Closed)

Created:
8 years, 4 months ago by hausner
Modified:
8 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support new getter syntax (no formal parameter list) Support both new and old getter syntax in the VM compiler. One co19 test becomes invalid, as it expects a compile error due to missing getter formal parameters. Committed: https://code.google.com/p/dart/source/detail?r=10541

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -11 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 5 chunks +23 lines, -8 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
8 years, 4 months ago (2012-08-10 22:30:07 UTC) #1
regis
LGTM http://codereview.chromium.org/10837208/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): http://codereview.chromium.org/10837208/diff/1/runtime/vm/object.h#newcode1526 runtime/vm/object.h:1526: // Returns true if this function represents a ...
8 years, 4 months ago (2012-08-10 22:41:07 UTC) #2
hausner
8 years, 4 months ago (2012-08-10 22:51:01 UTC) #3
Thank you.

http://codereview.chromium.org/10837208/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

http://codereview.chromium.org/10837208/diff/1/runtime/vm/object.h#newcode1526
runtime/vm/object.h:1526: // Returns true if this function represents a getter.
On 2012/08/10 22:41:08, regis wrote:
> You should comment that implicit getters are not recognized
> (RawFunction::kImplicitGetter or RawFunction::kConstImplicitGetter)
> Btw, why not?

Done. I just wanted to replace the "kind == kGetterFunction"  that appears at
several places in our code.

http://codereview.chromium.org/10837208/diff/1/runtime/vm/object.h#newcode1532
runtime/vm/object.h:1532: bool IsSetterFunction() const {
On 2012/08/10 22:41:08, regis wrote:
> You should comment that implicit setters are not recognized
> (RawFunction::kImplicitSetter)

Done.

Powered by Google App Engine
This is Rietveld 408576698