Issue 10837186: Rename privates directly, not via visitIdentifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837186: Rename privates directly, not via visitIdentifier. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename privates directly, not via visitIdentifier. R=smok@google.com Committed: https://code.google.com/p/dart/source/detail?r=10446

Patch Set 5 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -25 lines)			Patch
	M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1 2 3 4	8 chunks	+73 lines, -24 lines	0 comments	Download
	M	tests/language/language.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10837186/diff/1003/lib/compiler/implementation/dart_backend/placeholder_collector.dart File lib/compiler/implementation/dart_backend/placeholder_collector.dart (right): https://chromiumcodereview.appspot.com/10837186/diff/1003/lib/compiler/implementation/dart_backend/placeholder_collector.dart#newcode94 lib/compiler/implementation/dart_backend/placeholder_collector.dart:94: assert(send.receiver.source.slowToString() == 'this'); "send.receiver.isThis()" test should work too?

8 years, 4 months ago (2012-08-09 15:28:42 UTC) #2

Anton Muhin

8 years, 4 months ago (2012-08-09 15:42:00 UTC) #3

Thanks a lot for review, Roma, submitting.

https://chromiumcodereview.appspot.com/10837186/diff/1003/lib/compiler/implem...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10837186/diff/1003/lib/compiler/implem...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:94:
assert(send.receiver.source.slowToString() == 'this');
On 2012/08/09 15:28:42, Roman wrote:
> "send.receiver.isThis()" test should work too?

... and it's definitely better, thanks a lot, Roma.

Expand Messages | Collapse Messages

Issue 10837186: Rename privates directly, not via visitIdentifier. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages